Skip to content

Fix Garage S3 follow-up review feedback#45

Draft
henmohr wants to merge 1 commit into
mainfrom
fix/pr40-review-fixes
Draft

Fix Garage S3 follow-up review feedback#45
henmohr wants to merge 1 commit into
mainfrom
fix/pr40-review-fixes

Conversation

@henmohr

@henmohr henmohr commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This follow-up addresses the actionable review feedback from PR #40.

What changed

  • Read GARAGES3_KEY_ID in the Garage S3 config, with GARAGES3_KEY kept as a legacy fallback.
  • Clarified the Garage env var docs so GARAGES3_KEY is described as the key name and GARAGES3_KEY_ID as the access key ID used by Nextcloud.
  • Fixed the trusted-domains guidance to use space-separated values, matching the Nextcloud container behavior.
  • Added matching notes to the example env file in both English and Portuguese docs.

Why

  • The previous config path could start Nextcloud with the wrong Garage credential or fail when only the bootstrap-generated key ID was present.
  • The docs were describing trusted domains with the wrong separator.

Validation

  • php -l .docker/garages3.config.php
  • git diff --check

@henmohr henmohr requested a review from vitormattos July 14, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant